Skip to content

Conversation

@rahul-b-stack
Copy link

No description provided.

@rahul-b-stack rahul-b-stack requested a review from a team as a code owner January 19, 2026 08:03
Copy link

@Baaryan Baaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me
Can you please check with the Product team if they are fine with these scripts? In particular the module names, test file names and the scripts? Not sure if A, B, C, D etc sounds good from a product perspective

@Baaryan
Copy link

Baaryan commented Jan 19, 2026

@rahul-b-stack
Copy link
Author

@Baaryan I don't think I have the permission to run the above PR checks. Could you re-trigger them?

jest.config.js Outdated
maxWorkers: 5,
roots: ["src"],
testMatch: ["**/*.test.js"],
testMatch: ["**/test*.js"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Older tests would should running right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Older tests are not currently needed. We are planning to add new tests altogether.

jest.config.js Outdated
testMatch: ["**/test*.js"],
testPathIgnorePatterns: ["/node_modules/"],
testTimeout: 60 * 1000,
testTimeout: 30 * 1000,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is test timeout reduced?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test timeout of 30 seconds also works. 60 seconds was a bit high and was extending the duration of the build

package.json Outdated
"scripts": {
"sample-test": "browserstack-node-sdk jest src/sample.test.js",
"sample-test": "browserstack-node-sdk jest 'src/module[A-Z]/test.js'",
"sample-local-test": "browserstack-node-sdk jest src/sample-local.test.js",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we try to run the sample-local-test it will fail since above regex is modified.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the config to match all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants