-
Notifications
You must be signed in to change notification settings - Fork 31
Add diverse tests for TRA #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: tra
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me
Can you please check with the Product team if they are fine with these scripts? In particular the module names, test file names and the scripts? Not sure if A, B, C, D etc sounds good from a product perspective
|
Also, please run the PR checks for verification |
|
@Baaryan I don't think I have the permission to run the above PR checks. Could you re-trigger them? |
jest.config.js
Outdated
| maxWorkers: 5, | ||
| roots: ["src"], | ||
| testMatch: ["**/*.test.js"], | ||
| testMatch: ["**/test*.js"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Older tests would should running right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Older tests are not currently needed. We are planning to add new tests altogether.
jest.config.js
Outdated
| testMatch: ["**/test*.js"], | ||
| testPathIgnorePatterns: ["/node_modules/"], | ||
| testTimeout: 60 * 1000, | ||
| testTimeout: 30 * 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is test timeout reduced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test timeout of 30 seconds also works. 60 seconds was a bit high and was extending the duration of the build
package.json
Outdated
| "scripts": { | ||
| "sample-test": "browserstack-node-sdk jest src/sample.test.js", | ||
| "sample-test": "browserstack-node-sdk jest 'src/module[A-Z]/test.js'", | ||
| "sample-local-test": "browserstack-node-sdk jest src/sample-local.test.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we try to run the sample-local-test it will fail since above regex is modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the config to match all tests
No description provided.